Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unused deps #27

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: unused deps #27

merged 1 commit into from
Dec 11, 2023

Conversation

jdockerty
Copy link
Owner

After running the udeps command, these were the unused dependencies for the project.

cargo +nightly udeps --all-targets
    Checking gruglb v0.1.0 (/home/influx/work/gruglb)
    Finished dev [unoptimized + debuginfo] target(s) in 4.40s
unused dependencies:
`gruglb v0.1.0 (/home/influx/work/gruglb)`
└─── dependencies
     ├─── "rand"
     ├─── "serde_json"
     └─── "thiserror"
Note: They might be false-positive.
      For example, `cargo-udeps` cannot detect usage of crates that are only used in doc-tests.
      To ignore some dependencies, write `package.metadata.cargo-udeps.ignore` in Cargo.toml.

The tests still pass, which should ensure that they are not used in its core functionality and are safe to remove. I did a small manual test as well and that supports this conclusion too.

@jdockerty jdockerty self-assigned this Dec 11, 2023
@jdockerty jdockerty changed the title removed unused deps chore: unused deps Dec 11, 2023
@jdockerty jdockerty merged commit b23d096 into main Dec 11, 2023
1 check passed
@jdockerty jdockerty deleted the chore/unused-deps branch December 11, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant