foundation 6 theme #575
Merged
foundation 6 theme #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be great if it supports tabs format in array. Thanks a lot in advance. issue related: #744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds foundation6 theme. It's a start, probably needs more to cover all cases.
What it solves is the error message part as this is quite differently handled in foundation than in foundation5.
The panel component is gone in foundation6, this PR replaces the
.panelwith the new.calloutcomponent.Let me know if you are interested in this. If I should send a PR without the compiled files in dist, let me know, I was not sure what you prefer.
The README is not updated with this PR to document the new
foundation6theme. Let me know If you want me to do that.