Adding name param for cli profile name #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$name defaults to the sane 'default'. $title is now effectively ignored, other than its use in other titles.
Added conditional logic to support the profile naming convention within config, as defined by: http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html#cli-multiple-profiles
Updated config_concat.erb to support profile naming convention
|
Great work @jgnagy! Can you add some coverage for the |
|
I haven't had time to work on the rspec changes, but I welcome help if anyone is interested. |
|
@jgnagy I like this addition. I'll see if I can just do the specs myself 🔜. Thanks! |
This was referenced May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to issue #22 and allows users to specify an AWS profile name as a param. This is a potentially breaking change though, for users that expect
$titleto do what$profile_namenow does. I looked through your tests and I believe that this will still pass all of them as you didn't appear to be checking for the profile name itself anywhere. If I'm wrong, I'm assuming your CI will pick it up.