Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace log4j with logback #24

Closed
jdrem opened this issue Mar 6, 2022 · 3 comments
Closed

Replace log4j with logback #24

jdrem opened this issue Mar 6, 2022 · 3 comments
Labels
refactoring
Milestone
R1.0.2

Comments

@jdrem
Copy link
Owner

jdrem commented Mar 6, 2022

Log4j no longer in active development, should move to logback.
@jdrem jdrem added this to the R1.0.2 milestone Mar 6, 2022
@RishiKumarRay
Copy link

Do we have to change all the occurences of log4j with logback?

@jdrem
Copy link
Owner Author

jdrem commented Mar 7, 2022

The bigger problem is that log4j is a transitive dependency, which for an api like this is wrong. I need to make them test. I'm getting dependabot alerts about log4j, so I just want to change it to logback to fix those.

If I have time I'll do a new release today or tomorrow with those fixes.

jdrem added a commit that referenced this issue Mar 7, 2022
@jdrem
Replace log4j with logback. Make logback dependencies scope to test t…
883db18 
…o prevent transitive dependencies on them. Update slf4j to latest pre-beta version. #24
@jdrem jdrem mentioned this issue Mar 7, 2022
Merged
@jdrem
Copy link
Owner Author

jdrem commented Mar 8, 2022

Released in 1.0.2

@jdrem jdrem closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
R1.0.2
Development

No branches or pull requests
2 participants
@jdrem @RishiKumarRay