Implementing tv show keywords #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrouet
requested changes
Apr 2, 2024
| } | ||
|
|
||
| impl crate::prelude::Command for TVShowKeywords { | ||
| type Output = TVShowKeywordsResult; |
There was a problem hiding this comment.
I'm wondering what the id field in this struct refers to. If it's only the TV show id, then we could just consider Vec<Keyword> as the output type.
There was a problem hiding this comment.
id is indeed the tv show id. Tmdb likes to send it back.
After cheking, this kind of implementation is used in many routes, company images, alternative names, alternative titles, just to name a few, where the result could be simplified to a single vector.
Also endpoints like tv show images, or movie credits also serialize the id field where it could be skipped.
So what should be done ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.