Merge pull request #29 from gqcollins/master

navigate rounding errors in inv_exp_map()
jdtuck · Oct 12, 2023 · 56ded3e · 56ded3e
2 parents e1e8ada + b0e521d
commit 56ded3e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/R/geometry.R b/R/geometry.R
@@ -9,7 +9,13 @@ l2_curvenorm <- function(psi, time=seq(0,1,length.out=ncol(psi))){
 }
 
 inv_exp_map<-function(Psi, psi){
-  theta <- acos(inner_product(Psi,psi))
+  ip <- inner_product(Psi, psi)
+  if(ip < -1){
+    ip = -1
+  }else if(ip > 1){
+    ip = 1
+  }
+  theta <- acos(ip)
 
   if (theta < 1e-10){
     exp_inv = rep(0,length(psi))