-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asdf-java incompatibilities #2
Comments
I can dig into this more tomorrow. It's likely just that I'm missing some environment variable that asdf sets.
This is actually an issue with the plugin (arguably). It doesn't output any "normal" versions that start with a number. It's an issue in asdf as well:
I'm not sure what should happen here but it likely needs to be fixed in the java plugin. One thought I had is maybe it should use the |
oh, reading the code, it actually is importing some asdf source code. That obviously isn't there since asdf isn't installed. If you installed asdf (just didn't add it to your shell rc) that should fix it. It has to be in that directory though, so run:
We may need a longer term solution here though, especially if this is something happening in other plugins. |
Cool, yeah, not a blocker at all, just thought I'd surface it in case another plugin does break. I think the Java plugin (and to an extent Java) is just weird. I'd say it should default to openjdk, but I'm sure people would argue otherwise. I'm never installing asdf again! 😛 |
I explain this in the readme but the java plugin is actually probably the best suited to rtx over asdf (barring this hiccup). You don't need to setup the special asdf-java shell extension to get |
though, that's a theory, I'm not a java dev so maybe you can tell me how well it actually works :) |
As far as I know, |
I did test java somewhat and it seems to work reasonably well. It does throw this error but it isn't important. There is also the matter of there not being a default version. I think barring some rough solutions these both rely on changes within the plugin, or perhaps forking the java plugin into an RTX variant so that's the one that gets picked up when you run That said, there are a ton of other issues people have raised that I feel are more important so this one has dropped near the bottom of my queue. I'd be happy to consider any solutions here, or if the problems are bigger than I see let me know. I'll keep this open of course, I just figured I'd let you know I don't think it's super likely I'll get around to this in the near term. |
Thanks for the follow up! I'm not blocked or really effected by this. Thanks for making sure it's not a big issue. I'm good with this outcome, I have know problem if you want to close it. |
The problem with asdf is that it only has a notion of version for a particular plugin. Several plugins are meanwhile provided in various distributions/variants (e.g. Java: Azul, OpenJDK, ... or Python: Anaconda, PyPy, ...) So it rather should support something like |
I'm going to close as it seems this is resolved. The problem we talked about is really in asdf-java if it's anywhere. |
…kotlin.jvm-2.0.0 Bump org.jetbrains.kotlin.jvm from 1.9.24 to 2.0.0
There seems to be 2 (non-critical?) errors thrown with the Java plugin when installing a new Java version:
It seems to install fine though, not sure if it's worth investigating.
Also,
rtx install java
does not work. Not sure if it should though.The text was updated successfully, but these errors were encountered: