-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nushell.rs - Add explicit spread #1441
Conversation
Running mise with nushell in the latest release of nushell (currently [0.89.0](https://www.nushell.sh/blog/2024-01-09-nushell_0_89_0.html#spread-operator-for-commands)) results in the following warning: ```shell Error: × Automatically spreading lists is deprecated ╭─[/hREDACTED:35:1] 35 │ } else { 36 │ ^"rtx" $command $rest · ──┬── · ╰── Spreading lists automatically when calling external commands is deprecated and will be removed in 0.91. 37 │ } ╰──── help: Use the spread operator (put a '...' before the argument) ``` This change fixes the warning.
It looks like some tests are failing, but it isn't clear to me why just by reading the output. Some input on how to fix the issues would be helpful. |
you need to update the snapshots with |
Got it, thanks! |
@jdx Sorry, quick question. I ran |
I'm surprised it didn't error. You may need to install |
I just mentioned in the Discord I think we should make it so you can |
It did error because cargo insta wasn't installed at first, so I installed cargo-insta and tried again. After that, it worked. |
if nothing else, just manually edit the snapshots:
|
Thanks for fixing that! And thanks for the great work on such a great tool. I introduced this at work recently and it got great reviews from the devs that tried it. |
Running mise with nushell in the latest release of nushell (currently 0.89.0) results in the following warning:
This change fixes the warning.