fix: no panic on missing current dir #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just realized that global/system config could still be read, considering this is such a niche case I assume it doesn't matter, still would it be worth it to open a separate PR for that? |
|
we should probably support that. Is there a user that is going to have problems with it? I would expect probably not for a long time, but I also think it will happen one day and if we don't fix this now I think it would be very hard to diagnose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell is spammed with a panic message after each command if the current directory is not available, with this PR simply mise ignores/logs if that is the case instead of a hard crash.
I noticed the issue while browsing a remote snapshot directory tree that was FUSE mounted by kopia.