Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): introduce rust based integration suite #1612

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Ajpantuso
Copy link
Contributor

Summary

Introduces an integration suite in rust to complement the e2e suite. Some e2e tests can be converted to simpler integration tests which is partially demonstrated here, but others which rely on shell integration for completeness should not be.

Additional Notes

  • For the e2e tests being converted it will be important to scrutinize what global setup from the e2e suite must be included for valid testing
  • Test helpers are being built as I go so are highly subject to change

@Ajpantuso
Copy link
Contributor Author

@jdx PTAL. Can keep this minimal in scope if you want to just help with #1600, but I'm happy to flesh this out in to a more complete refactor of e2e tests, of course leaving the true e2e tests alone. Obviously if you don't like the style of integration I can just hack around the current test_run file instead.

To get these to run from this commit you just need to uncomment these lines

@jdx
Copy link
Owner

jdx commented Feb 3, 2024

I'm down to try it

Cargo.toml Outdated Show resolved Hide resolved
@Ajpantuso Ajpantuso force-pushed the apantuso/integration_tests branch 8 times, most recently from f49c967 to 889f5c1 Compare February 11, 2024 19:42
@Ajpantuso Ajpantuso force-pushed the apantuso/integration_tests branch 4 times, most recently from 128fb59 to ae1a8ea Compare February 14, 2024 01:25
@Ajpantuso Ajpantuso marked this pull request as ready for review February 14, 2024 01:30
@Ajpantuso
Copy link
Contributor Author

@jdx alright I think this is good for a review. Took too long and bigger than I wanted, but I like the idea of having a DSL. Should hopefully make it easier for contributors to add integration tests. Noted in tests/cli/mod.rs the e2e tests which have not been converted. Also did not update the test targets for the time being, but should be trivial to add the filters to exclude these from test:units when desired.

@jdx jdx merged commit 6c656f8 into jdx:main Feb 20, 2024
7 checks passed
@Ajpantuso Ajpantuso deleted the apantuso/integration_tests branch February 21, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants