Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bun): install bunx symlink #1688

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix(bun): install bunx symlink #1688

merged 1 commit into from
Feb 21, 2024

Conversation

booniepepper
Copy link
Contributor

Closes #1680

@booniepepper booniepepper marked this pull request as draft February 20, 2024 21:41
@booniepepper
Copy link
Contributor Author

Oops, should have started with a download of the distribution zip instead of reading docs

The zip files from bun contain only the bun executable, and bunx is very literally an alias for bun x

@booniepepper
Copy link
Contributor Author

More specifically, if I install with the script at https://bun.sh/install then I get bunx as a symlink to bun. Sounds like the bun binary checks its argv[0] process name to decide behavior, I've done that before too for shebang support, it's a fun trick

@booniepepper booniepepper marked this pull request as ready for review February 20, 2024 22:09
@booniepepper booniepepper changed the title fix(bun): install bunx fix(bun): install bunx symlink Feb 20, 2024
src/plugins/core/bun.rs Outdated Show resolved Hide resolved
@jdx
Copy link
Owner

jdx commented Feb 20, 2024

it'd be good to add a line to e2e/test_bun for a simple test. You could execute this: bunx oclif --version

src/plugins/core/bun.rs Outdated Show resolved Hide resolved
@jdx jdx merged commit 28d4154 into jdx:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command not found: bunx
2 participants