Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: very basic dependency support #1788

Merged
merged 3 commits into from
Mar 17, 2024
Merged

feat: very basic dependency support #1788

merged 3 commits into from
Mar 17, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Mar 16, 2024

all this does is wait to install things like python before poetry, erlang before elixir, etc. It doesn't include them by default, just waits for them to finish installing if they're in process.

This way if you run mise install and have python and poetry, it won't start installing poetry until python is installed and can be used as a dependency. It does require that you put these in order manually, if they're not, it just won't wait.

It's basically just calling "sleep()" if one of its dependencies is currently installing. It's far from a comprehensive dependency solution with versions and things. That said, it's a simple solution not likely to cause any problems and should solve some of the most common issues around this.

cc @travisbhartwell

These are all hardcoded for now but it would be possible to expose it to asdf plugins so they could specify their own dependencies.

@jdx jdx changed the title dependencies feat: very basic dependency support Mar 16, 2024
Copy link

codacy-production bot commented Mar 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% 57.14%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (03aca86) 16866 14064 83.39%
Head commit (d33b687) 16894 (+28) 14080 (+16) 83.34% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1788) 28 16 57.14%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jdx jdx force-pushed the dependencies branch 4 times, most recently from c5b0afa to db063c6 Compare March 17, 2024 00:58
@jdx jdx enabled auto-merge (squash) March 17, 2024 02:23
@jdx jdx merged commit 7a53a44 into main Mar 17, 2024
8 checks passed
@jdx jdx deleted the dependencies branch March 17, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant