Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jq Installed Using x86_64 on Apple Silicon using mise #1804

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

roele
Copy link
Contributor

@roele roele commented Mar 20, 2024

This fixes #1767 and fixes #1762 by referencing the forked and adapted repository for jq.

@jdx jdx merged commit 2ea978d into jdx:main Mar 20, 2024
7 checks passed
@jdx
Copy link
Owner

jdx commented Mar 20, 2024

@roele I'm getting a weird error in the release-plz job since merging this, any clue what it might be? https://github.com/jdx/mise/actions/runs/8366173390/job/22906321446

@roele
Copy link
Contributor Author

roele commented Mar 20, 2024

@jdx i saw some odd behaviour when running the asdf-plugin tests for linux where jq was downloaded successfully but a wrong version was shown as if the plugin version was not on the PATH.

https://github.com/mise-plugins/asdf-jq/actions/runs/8366519156/job/22906931040

@jdx
Copy link
Owner

jdx commented Mar 20, 2024

yeah I suspected wrong version but I tested your plugin change locally and it was 1.7.1 as expected

@roele
Copy link
Contributor Author

roele commented Mar 20, 2024

I did not test on linux besides the asdf-plugin-test via GH action so maybe there is some issues with the supported architectures?

@jdx
Copy link
Owner

jdx commented Mar 20, 2024

I wonder if it is this: https://github.com/mise-plugins/asdf-jq/blob/3b11d736681eecbd3359e9ce79ab319026717a83/bin/list-all#L10

not sure what shell that runs in

@roele
Copy link
Contributor Author

roele commented Mar 20, 2024

I can reproduce the behaviour within the devcontainer...

root ➜ /workspaces/mise (main) $ target/debug/mise install jq
 mise /workspaces/mise/.mise.toml is not trusted. Trust it? Yes
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1669k  100 1669k    0     0  1709k      0 --:--:-- --:--:-- --:--:-- 15.0M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  2129  100  2129    0     0   2463      0 --:--:-- --:--:-- --:--:--  2463
mise jq@1.7.1      ✓ installed                                                                                                                                                               root ➜ /workspaces/mise (main) $ jq --version
jq-1.6
root ➜ /workspaces/mise (main) $ which jq
/usr/bin/jq

but that stems from the fact that mise is not installed so the downloaded binary is not on the path automatically and the system one is used

@jdx
Copy link
Owner

jdx commented Mar 20, 2024

is the tarball structure not what we're expecting after the refactor?

@jdx
Copy link
Owner

jdx commented Mar 20, 2024

ahh, I think I see the problem:

mise  main ❯ ls ~/.mise/installs/jq/1.7.1/
jq*

that should be inside of a "bin" directory, so it should be ~/.mise/installs/jq/1.7.1/bin/jq

@roele
Copy link
Contributor Author

roele commented Mar 20, 2024

@roele
Copy link
Contributor Author

roele commented Mar 20, 2024

test also looks better now https://github.com/mise-plugins/asdf-jq/actions/runs/8366902152/job/22908120500
odd that this worked fine on macOS though...

@mise-en-dev mise-en-dev mentioned this pull request Mar 20, 2024
@roele roele deleted the issues/1767 branch March 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jq Installed Using x86_64 on Apple Silicon Using Mise Cannot use kc-workspace/asdf-jq with latest version
2 participants