fix: incorrect stdout for mise shell function in xonsh #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggdr
force-pushed
the
fix_shell_subcommand_xonsh
branch
3 times, most recently
from
dceea0b
to
5963167
Compare
|
I think it'd be better if we just found out why CLICOLOR_FORCE isn't working and fixed that directly |
|
The coloring problem is only a side-effect of this fix, so it should imho have no bearing on whether this fix should be accepted or not. The fix addresses stdio within the xonsh shell which I handled incorrectly, thereby breaking pipe-ability. You can read about that here: xonsh/xonsh#5316 |
jdx
force-pushed
the
main
branch
2 times, most recently
from
fad123b
to
d13511e
Compare
yggdr
force-pushed
the
fix_shell_subcommand_xonsh
branch
from
5963167
to
b085fce
Compare
The old implementation had issues with piping the result since stdout/stderr was not acutally captured in the shell but directly printed to the terminal. The fix here unfortunately effectivly turns off colors in mise, as mise seems to not honor CLICOLOR_FORCE et. al. environment variables as per jdx#1836
yggdr
force-pushed
the
fix_shell_subcommand_xonsh
branch
from
b085fce
to
104c14a
Compare
yggdr
changed the title
|
I'd like to be able to fix the xonsh piping issue without regressing on color output. |
|
I'd rather have a functionally working shell incl. pipeability than colours, nice though they may be. That the colours work at all in xonsh with the current code is a mere accident and side effect of my buggy original implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation had issues with piping the result since stdout/stderr was not acutally captured in the shell but directly printed to the terminal.
The fix here unfortunately effectivly turns off colors in mise, as mise seems to not honor CLICOLOR_FORCE et. al. environment variables as per #1836