-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use a metadata file for forges #1909
Conversation
b2e96c3
to
84b4854
Compare
I think we need to modify our strategy. Maybe we need a metadata file to store the real name |
Agreed, the path is not suitable and will most likely continue to cause problems no matter what separator we use. |
I think it's worth doing though. For example, I bet |
Gave it a first shot but i'm not sure if we should use a structured file instead? |
0a4b8b3
to
33862a5
Compare
4c9f13d
to
d23c017
Compare
a383a62
to
3c9920e
Compare
This is a follow up on #1905 attempting to move the "un-dirname" logic out of the
ForgeArg
into theForge
implementations.Additionally it seems for
Go
while package names cannot have-
, module names can and often do. So the logic forGo
will also not work reliably. For example https://pkg.go.dev/search?q=http reveals all sorts of exceptions.Using a
+
as separator would yield better results but i'm afraid thats not easy to change now is it?