Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support private packages #1

Closed
jdx opened this issue Jun 15, 2015 · 14 comments
Closed

support private packages #1

jdx opened this issue Jun 15, 2015 · 14 comments

Comments

@jdx
Copy link
Owner

jdx commented Jun 15, 2015

Originally this project was needed to ensure that only authenticated users could publish packages, but they needed to be installable by anyone. For most projects, however, you would want only authenticated users to be able to publish or install packages.

This will have to be a configurable option.

@zeke
Copy link
Contributor

zeke commented Sep 17, 2015

I'm watching this repo :)

@jdx
Copy link
Owner Author

jdx commented Sep 17, 2015

this is actively used! https://cli-npm.heroku.com/package-json-to-readme

@raulb
Copy link

raulb commented Sep 17, 2015

Hi @zeke 👋

@zeke
Copy link
Contributor

zeke commented Sep 18, 2015

🙌

jdx pushed a commit that referenced this issue Feb 24, 2016
@resistdesign
Copy link

👍

@jdx
Copy link
Owner Author

jdx commented Jul 28, 2016

I've got an idea how to make this work and still have the CDN stuff. Hopefully I'll get some time to work on it soon-ish.

@ealves-pt
Copy link
Contributor

ealves-pt commented Aug 21, 2016

@dickeyxxx I don't know what is your plan but it would be nice if we could manage organizations, teams and users with it.

@jdx
Copy link
Owner Author

jdx commented Aug 21, 2016

That would be pretty complicated. I wonder if I could piggyback on the existing npm commands to manage orgs though.

@danielo515
Copy link

I'm confused about this, are the published packages publicly available? There is no way to make them private?

@milankinen
Copy link
Contributor

milankinen commented Jan 3, 2017

Hi @dickeyxxx!

I could make a PR making read/write auth configurable if it's ok for you. In my implementation there would be two environment variables:

  • AUTH_WRITE=true|false (defaults true)
    • All post/put/delete routes except auth (= basically routes having auth middleware enabled currently)
  • AUTH_READ=true|false (defaults false)
    • All get routes except index and auth

auth route authentication would remain as it is (non-configurable). No CDN support though.. 😕

Thoughts?

@jdx
Copy link
Owner Author

jdx commented Jan 5, 2017

@milankinen that sounds reasonable, but maybe prefix the var with NPM_REGISTER_* so they won't conflict with anything else

@milankinen
Copy link
Contributor

@dickeyxxx Absolutely! 👍

@danielo515
Copy link

What is the state of this? I would love to use this in production,but I need packages to be totally private .

Regards

@milankinen
Copy link
Contributor

milankinen commented Jan 20, 2017

Sorry I had other pending tasks that I had to complete first, but finally here is my first attempt: #62

@jdx jdx closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants