-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kaufman Adaptive Moving Average #86
Conversation
It seems that the only issue is missing flake8 formatting. Sorry i don't have that installed. |
Thanks for the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 95.12% 95.39% +0.26%
==========================================
Files 3 3
Lines 1087 1129 +42
==========================================
+ Hits 1034 1077 +43
+ Misses 53 52 -1
Continue to review full report at Codecov.
|
We should be good now. It is unclear to me why the Python 2.7 test fails. I specifically tested it with a new 2.7 environment on my machine and the test passed without issue. |
It' OK. Let me deal with it when I have time. I will merge this PR when I have the solution. |
The indicator was tested against the reference investopedia article. It has more settings than other indicators, so the name could be parsed into five parts now.
close_10_kama_2_30
has three settings:
To make sure regular indicators are parsed as usual, only those within the tuple MULTI_SPLIT_INDICATORS will be parsed into five parts.