Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed crash if details inside of tabs #428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anatolykopyl
Copy link

Fixes #364

If Details was in a non default TabItem, then it was not accessible by puppeteer.
Changed the .click() to a click inside of an .evaluate().

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.32%. Comparing base (0e27e41) to head (e05a883).

Files Patch % Lines
src/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         792      792           
  Branches       35       35           
=======================================
  Hits          755      755           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Node is either not clickable or not an Element when <details> is inside <tabs>
1 participant