Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to follow or not symlinks in local filesystems #52

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

agouil
Copy link
Contributor

@agouil agouil commented May 31, 2023

Adds an option to the client to follow or not follow symlinks in the local filesystem during a sync command.

This is behaving similar to how the AWS CLI behaves if the --no-follow-symlinks option is passed.
By default the client will follow symlinks.

This is addressing this issue of skipping broken symlinks during a local to bucket sync.

@agouil
Copy link
Contributor Author

agouil commented May 31, 2023

I didn't added the docs in this PR as the links in the files wouldn't generate correctly from my fork.

@jeanbmar jeanbmar merged commit aff45e9 into jeanbmar:master Jun 1, 2023
1 check failed
@jeanbmar jeanbmar linked an issue Jun 1, 2023 that may be closed by this pull request
@jeanbmar
Copy link
Owner

jeanbmar commented Jun 1, 2023

Great addition @agouil thank you!

@agouil agouil deleted the no-follow-symlinks-option branch June 1, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync not following symlinks
2 participants