Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of bad ranking #1

Closed
dmnd opened this issue Oct 19, 2015 · 1 comment
Closed

Example of bad ranking #1

dmnd opened this issue Oct 19, 2015 · 1 comment

Comments

@dmnd
Copy link

dmnd commented Oct 19, 2015

Thanks for improving Atom's file finder, it's something that's needed improvement for a long time!

I recently installed your improved version and ran into a case where I think it could be better. Here it is:

image

@jeancroy
Copy link
Owner

First thank you for taking the time to make a report.
There's definitively a tuning phase needed.

I've just committed an update that pass your example.
fddaf71

Penalty for overall path length has been decreased, and to compensate penalty for base-name path length has been increased.

I'm not really sure how to best handle updating this. I'll probably emit a minor revision and people will have to do a npm update. I'll probably have to talk to the atom team too.

In the meantime feel free to hack the version in node_module if you want to test if you like new weights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants