Use react-native-community CameraRoll rather than the one from core react-native #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshaposhnik
changed the title
|
Would love to see this pull request merged. It finally fixed all the quirks I was experiencing using the react-native cameraroll implementation. Please update the dependency to react-native-community/cameraroll - it took me hours to figure out what exactly is wrong. And it seems there are others dealing with the same issue: |
sibelius
reviewed
Nov 19, 2019
| @@ -127,6 +127,7 @@ android { | |||
|
|
|||
| dependencies { | |||
| compile fileTree(dir: "libs", include: ["*.jar"]) | |||
| compile project(':@react-native-community_cameraroll') | |||
There was a problem hiding this comment.
autolink should manage this
sibelius
reviewed
Nov 19, 2019
| @@ -7,6 +7,7 @@ | |||
| "url": "https://github.com/jeanpan/react-native-camera-roll-picker/issues" | |||
| }, | |||
| "dependencies": { | |||
| "@react-native-community/cameraroll": "^1.1.1", | |||
There was a problem hiding this comment.
this should be a peer dep
|
fixed here #102 tks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered an issue with react-native 0.59.9, when I use groupTypes='All', it's showing some duplicates in iOS. I've tried to use react-native-community/cameraroll (which is created as a part of lean core project), and now it's all working correctly. In any case it should be updated sooner or later to use this dependency, as the react-native core package will be no longer updated from some point (and it lags behind already).