-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add possibility to specify server-id #21
Conversation
BTW, I opened this PR originally, because the official speedtest CLI is able to measure >900MBit/s for my line. But this version here only get about 280 MBit/s . Both running on my Pine64 (arm64) board. Maybe you have an idea, why... |
Nice internet :). I haven't seen any differences in speed reported by speedtest-cli and prometheus_speedtest; at least at the 85 MiB I'm getting. We're just a thin wrapper around the tool. It could be the client options we're setting. This server flag should help, thank you. |
Ah I probably should have been more specific. When I was referring to "the official speedtest CLI" I did not mean the python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just these couple None
vs []
nits then LGTM.
Thanks for your feedback. Incorporated all your requested changes. BTW, I reported the wrong measurements downstream, but was not very helpful: https://github.com/sivel/speedtest-cli/issues/716#issuecomment-610788176 |
Thank you! |
To be have less variance in the measurements I'd like to always use the same server and not rely on the auto-detection which sometimes selects pretty bad servers.
Not much python experience here, so hope the PR is ok :)