Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComponentWillReceiveProps & ComponentWillMount are deprecated #169

Open
vikjovanov opened this issue Aug 16, 2019 · 6 comments · May be fixed by #170
Open

ComponentWillReceiveProps & ComponentWillMount are deprecated #169

vikjovanov opened this issue Aug 16, 2019 · 6 comments · May be fixed by #170

Comments

@vikjovanov
Copy link

Hi,

When I use react-native-slider, I have multiple warning box that says:

  • ComponentWillReceiveProps is deprecated and will be removed in the next major version.
  • ComponentWillMount is deprecated and will be removed in the next major version.

I just wanted to know if it is planned to fix that?

Thanks
@IntelliJAbhishek
Copy link

looks like this repo is not being maintained.

@vikjovanov
Copy link
Author

Yes I know, I finally cloned the project and I made my own fix.

@IntelliJAbhishek
Copy link

@vikjovanov it would be greatfull if you open a PR with your fix.

@GamgeeNL GamgeeNL linked a pull request Sep 2, 2019 that will close this issue
Open
@abodehq
Copy link

abodehq commented Sep 22, 2019

please check this using react hooks and functional component:
https://www.npmjs.com/package/azir-slider

@brdar
Copy link

brdar commented Dec 15, 2019

I made npm package with issue fixed here:
https://www.npmjs.com/package/@brlja/react-native-slider

@superKalo
Copy link

@jeanregisser , please take a quick look at the PR and maybe merge it 🙏

Causing annoying warnings on our side too and I really don't want to switch to another package.

@yskoht yskoht mentioned this issue Sep 24, 2020
Merged
@GuillaumeRZ GuillaumeRZ mentioned this issue Jun 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

* componentWillMount and componentWillReceiveProps refactored GamgeeNL/react-native-slider
5 participants
@abodehq @superKalo @brdar @IntelliJAbhishek @vikjovanov