Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* componentWillMount and componentWillReceiveProps refactored #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

* componentWillMount and componentWillReceiveProps refactored #170

wants to merge 1 commit into from

Conversation

GamgeeNL
Copy link

@GamgeeNL GamgeeNL commented Sep 2, 2019

Fixes #169

@GuiCavi
Copy link

GuiCavi commented Oct 7, 2019

Can this be merged already? Any contributors to the rescue?

@GamgeeNL
Copy link
Author

GamgeeNL commented Oct 7, 2019

Any contributors to the rescue? @jeanregisser ?

jayli3n
jayli3n approved these changes Dec 11, 2019
View reviewed changes
Copy link

@jayli3n jayli3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please merge.

@brdar
Copy link

brdar commented Dec 14, 2019

I made npm package with issue fixed here:
https://www.npmjs.com/package/@brlja/react-native-slider

@danilocanalle
Copy link

Where is the merge ?

@lucasnovelo
Copy link

lucasnovelo commented Aug 17, 2020 •
edited
Loading

Can we merge this one? @jeanregisser

@amoghwagh
Copy link

Can we please merge this? @jeanregisser

@yskoht yskoht mentioned this pull request Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayli3n jayli3n jayli3n approved these changes

@kasun-ascentic kasun-ascentic kasun-ascentic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComponentWillReceiveProps & ComponentWillMount are deprecated
8 participants
@GamgeeNL @GuiCavi @brdar @danilocanalle @lucasnovelo @amoghwagh @jayli3n @kasun-ascentic