Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for React Native to 0.43.3+ / React 16+ #67

Merged
merged 1 commit into from
Jun 3, 2017
Merged

Fix for React Native to 0.43.3+ / React 16+ #67

merged 1 commit into from
Jun 3, 2017

Conversation

brunolemos
Copy link
Contributor

There were some breaking changes on React 16+ that broke this lib. This PR fixes it. See article.

@brunolemos brunolemos mentioned this pull request Apr 10, 2017
Closed
@jeanregisser
Copy link
Owner

Thanks @brunolemos.
You bundled this change with other changes (renderToHardwareTextureAndroid? removed shouldComponentUpdate?) though.
I'll extract the needed bit.

@brunolemos
Copy link
Contributor Author

@jeanregisser Ok. I think its mostly the renderToHardwareTextureAndroid part, shouldComponentUpdate was replaced by PureComponent which already does this by default

@jeanregisser jeanregisser merged commit 1995b92 into jeanregisser:master Jun 3, 2017
@jeanregisser
Copy link
Owner

Thanks for this @brunolemos 👍

This was referenced Jun 3, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunolemos @jeanregisser