Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support rocket =0.5.0-rc.4 #48

Closed
kije opened this issue Nov 3, 2023 · 1 comment
Closed

Update to support rocket =0.5.0-rc.4 #48

kije opened this issue Nov 3, 2023 · 1 comment
Assignees

Comments

@kije
Copy link
Contributor

kije commented Nov 3, 2023

First off, thanks for this great crate! :)

Rocket 0.5.0-rc.4 was just released with several breaking changes.

Relevant:

  • Outcome::Failure was renamed to Outcome::Error.
  • change to Cookie::build
error[E0599]: no variant or associated item named `Failure` found for enum `Outcome` in the current scope
   --> /.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket_oauth2-0.5.0-rc.2/src/lib.rs:431:33
    |
431 |                 return Outcome::Failure((
    |                                 ^^^^^^^ variant or associated item not found in `Outcome<_, (Status, _), Status>`

error[E0599]: no variant or associated item named `Failure` found for enum `Outcome` in the current scope
   --> /.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket_oauth2-0.5.0-rc.2/src/lib.rs:453:33
    |
453 |                 return Outcome::Failure((
    |                                 ^^^^^^^ variant or associated item not found in `Outcome<_, (Status, _), Status>`

error[E0599]: no variant or associated item named `Failure` found for enum `Outcome` in the current scope
   --> /.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket_oauth2-0.5.0-rc.2/src/lib.rs:478:37
    |
478 |                     return Outcome::Failure((
    |                                     ^^^^^^^ variant or associated item not found in `Outcome<_, (Status, _), Status>`

error[E0599]: no variant or associated item named `Failure` found for enum `Outcome` in the current scope
   --> /.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket_oauth2-0.5.0-rc.2/src/lib.rs:511:26
    |
511 |                 Outcome::Failure((Status::BadRequest, e))
    |                          ^^^^^^^ variant or associated item not found in `Outcome<_, (Status, _), Status>`

error[E0061]: this function takes 1 argument but 2 arguments were supplied
   --> /.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket_oauth2-0.5.0-rc.2/src/lib.rs:710:13
    |
710 |             Cookie::build(STATE_COOKIE_NAME, state)
    |             ^^^^^^^^^^^^^                  -------
    |                                            | |
    |                                            | unexpected argument of type `std::string::String`
    |                                            help: remove the extra argument
    |
note: associated function defined here
   --> /.cargo/registry/src/index.crates.io-6f17d22bba15001f/cookie-0.18.0/src/lib.rs:324:12
    |
324 |     pub fn build<C: Into<Cookie<'c>>>(base: C) -> CookieBuilder<'c> {
    |        
@jebrosen
Copy link
Owner

Thanks - I have merged #49 and released https://crates.io/crates/rocket_oauth2/0.5.0-rc.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants