Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Interfaces in add_interface #93

Closed
andrew-hoff opened this issue May 12, 2022 · 2 comments
Closed

Check Interfaces in add_interface #93

andrew-hoff opened this issue May 12, 2022 · 2 comments

Comments

@andrew-hoff
Copy link

Is there any reason why you don't call check_interfaces here? Would that not reduce latency when adding a new interface at runtime? A bit of experimentation on my part seems to show reduced latency when I make that change. That having been said, I'm new to this repo, so I might be misinterpreting expected behavior.

@jech
Copy link
Owner

jech commented May 16, 2022

Good catch, fixed in 3d8aec4. (I'm scheduling an interface check 200ms later, since checking interfaces for each new interface would cause quadratic behaviour at startup.)

@jech jech closed this as completed May 16, 2022
@andrew-hoff
Copy link
Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants