v4-over-v6 #56
v4-over-v6 #56
Conversation
| rc = network_prefix(message[2], message[4], message[5], | ||
| message + 12, | ||
| message[2] == 1 ? v4_prefix : v6_prefix, | ||
| (message[2] == AE_IPV4 ? v4_prefix : |
There was a problem hiding this comment.
Why use parentheses surrounding the ternary expression?
There was a problem hiding this comment.
Mostly for visual grouping, as this spans on multiple lines. If you'd rather not have those, I could remove it.
tobast
force-pushed
the
tobast/v6tethered-reimplem
branch
from
9776642
to
43ac425
Compare
tobast
force-pushed
the
tobast/v6tethered-reimplem
branch
5 times, most recently
from
dbb13a4
to
6b7bfd5
Compare
tobast
force-pushed
the
tobast/v6tethered-reimplem
branch
from
6b7bfd5
to
6ffcc56
Compare
util.c
Outdated
| int | ||
| ae_is_v4(int ae) | ||
| { | ||
| return ae == 1 || ae == 240; |
There was a problem hiding this comment.
Why aren’t you using the AE_ constants here? If you’re only using ae_is_v4 in message.c you could put the function there, and you wouldn’t have to include message.h or to put the constant definitions in a weird place.
There was a problem hiding this comment.
I'm not using it anywhere else, but this looks like a function that might be needed somewhere else later on. I might be wrong here, though.
I did that a while ago, but I think that including message.h in util broke things and there was no trivial way to fix this, so it seemed easier to just do it this way.
There was a problem hiding this comment.
I don’t have a hard opinion on this, though it feels wrong not to use the AE_ constants everywhere.
that including message.h in util broke things
Does not surprise me 🙂 :
There was a problem hiding this comment.
This simply indicates that this function doesn't belong in util. Util is for generic utility functions that are not closely tied to Babel.
|
Oh, you can also add yourself to the CREDITS file! |
Detection is based on the kernel version, and can be overridden by
the configuration option `v4-over-v6 {true|false}`. If v4-over-v6 is not
supported, ignores v4-over-v6 routes early.
In the following topology A --[v4]-- B --[v6]-- C if B does not support v4ov6 (eg. because of an old kernel), it can nevertheless announce a v4-over-v6 route to C, since the route in its own routing table is pure v4.
tobast
force-pushed
the
tobast/v6tethered-reimplem
branch
from
46ca871
to
a4aebc7
Compare
This merge request implements v4-over-v6.