Clean more equalities in tests

Fixes #18
jecisc · Apr 24, 2020 · 8b8d6c8 · 8b8d6c8
1 parent d513f1b
commit 8b8d6c8
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 0 deletions.
diff --git a/resources/doc/documentation.md b/resources/doc/documentation.md
@@ -67,6 +67,14 @@ Here is the list of rewrites it will apply:
 | `x deny y equals: true` | `x deny: y` |
 | `x assert: y equals: false` | `x deny: y` |
 | `x deny: y equals: false` | `x assert: y` |
+| `x assert: y identicalTo: true` | `x assert: y` |
+| `x deny: y identicalTo: true` | `x deny: y` |
+| `x assert: y identicalTo: false` | `x deny: y` |
+| `x deny: y identicalTo: false` | `x assert: y` |
+| `x assert: y == true` | `x assert: y` |
+| `x deny: y == true` | `x deny: y` |
+| `x assert: y == false` | `x deny: y` |
+| `x deny: y == false` | `x assert: y` |
 
 *Conditions for the cleanings to by applied:*
 - Only subclasses of TestCase are cleaned.

diff --git a/src/Chanel-Tests/ChanelTestEqualityCleanerTest.class.st b/src/Chanel-Tests/ChanelTestEqualityCleanerTest.class.st
@@ -43,6 +43,26 @@ ChanelTestEqualityCleanerTest >> testAssertIdenticalTo [
 	self assert: 'self assert: 3 == 2' isRewrittenAs: 'self assert: 3 identicalTo: 2'
 ]
 
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testAssertIdenticalToFalse [
+	self assert: 'self assert: 3 == false' isRewrittenAs: 'self deny: 3'
+]
+
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testAssertIdenticalToFalse2 [
+	self assert: 'self assert: 3 identicalTo: false' isRewrittenAs: 'self deny: 3'
+]
+
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testAssertIdenticalToTrue [
+	self assert: 'self assert: 3 == true' isRewrittenAs: 'self assert: 3'
+]
+
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testAssertIdenticalToTrue2 [
+	self assert: 'self assert: 3 identicalTo: true' isRewrittenAs: 'self assert: 3'
+]
+
 { #category : #tests }
 ChanelTestEqualityCleanerTest >> testDenyEquals [
 	self assert: 'self deny: 3 = 2' isRewrittenAs: 'self deny: 3 equals: 2'
@@ -73,6 +93,26 @@ ChanelTestEqualityCleanerTest >> testDenyIdenticalTo [
 	self assert: 'self deny: 3 == 2' isRewrittenAs: 'self deny: 3 identicalTo: 2'
 ]
 
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testDenyIdenticalToFalse [
+	self assert: 'self deny: 3 == false' isRewrittenAs: 'self assert: 3'
+]
+
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testDenyIdenticalToFalse2 [
+	self assert: 'self deny: 3 identicalTo: false' isRewrittenAs: 'self assert: 3'
+]
+
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testDenyIdenticalToTrue [
+	self assert: 'self deny: 3 == true' isRewrittenAs: 'self deny: 3'
+]
+
+{ #category : #tests }
+ChanelTestEqualityCleanerTest >> testDenyIdenticalToTrue2 [
+	self assert: 'self deny: 3 identicalTo: true' isRewrittenAs: 'self deny: 3'
+]
+
 { #category : #tests }
 ChanelTestEqualityCleanerTest >> testDoesNotRemoveExtensions [
 	class

diff --git a/src/Chanel/ChanelTestEqualityCleaner.class.st b/src/Chanel/ChanelTestEqualityCleaner.class.st
@@ -53,6 +53,14 @@ ChanelTestEqualityCleaner >> equalityRewriter [
 		replace: '`@receiver deny: `@arg = true' with: '`@receiver deny: `@arg';
 		replace: '`@receiver assert: `@arg = false' with: '`@receiver deny: `@arg';
 		replace: '`@receiver deny: `@arg = false' with: '`@receiver assert: `@arg';
+		replace: '`@receiver assert: `@arg identicalTo: true' with: '`@receiver assert: `@arg';
+		replace: '`@receiver deny: `@arg identicalTo: true' with: '`@receiver deny: `@arg';
+		replace: '`@receiver assert: `@arg identicalTo: false' with: '`@receiver deny: `@arg';
+		replace: '`@receiver deny: `@arg identicalTo: false' with: '`@receiver assert: `@arg';
+		replace: '`@receiver assert: `@arg == true' with: '`@receiver assert: `@arg';
+		replace: '`@receiver deny: `@arg == true' with: '`@receiver deny: `@arg';
+		replace: '`@receiver assert: `@arg == false' with: '`@receiver deny: `@arg';
+		replace: '`@receiver deny: `@arg == false' with: '`@receiver assert: `@arg';
 		replace: '`@receiver assert: `@arg equals: true' with: '`@receiver assert: `@arg';
 		replace: '`@receiver deny: `@arg equals: true' with: '`@receiver deny: `@arg';
 		replace: '`@receiver assert: `@arg equals: false' with: '`@receiver deny: `@arg';