This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Rewrite config #272
Open
Rewrite config #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefansArya
reviewed
Jan 3, 2018
config/default.php
Outdated
| @@ -17,7 +17,7 @@ | |||
| */ | |||
| $config['debug'] = false; | |||
|
|
|||
| /** | |||
| /* | |||
| * Enable the YouTube signature decipher function | |||
| * WARNING: This downloads javascript code from a 3rd party server and interprets it! | |||
| * This MAY harm your server, if the 3rd party server delivers malicious code! | |||
There was a problem hiding this comment.
I think it would be impossible to execute malicious code with the current decipher script. The current decipher didn't execute the raw code instead using matched command dictionary to reverse, splice, or swapping signature arrays..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This PR rewrites the configuration file and the Config class. The point of this PR is an easier format for non-technical user because the line
$config['enable_youtube_decipher_signature'] = false;is easier to set than the current version:
The new Config class has also a built-in transformation so we can modify the configuration but can keep care of the existing user configurations. We can also track the deprecated configuration in the custom.php and notify the user about the changes.