This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Better handle hostnames vs domains #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to differ between hostnames and domains when we look for a zone.
This way, either we pass a hostname or a zone we will find the right Route53 zone ID. For example:
We want to create a certificate for a domain called
example.com: the script will find it right away and return the zone ID.But, if we want to create a certificate for a hostname
foo.example.comwhich is in the zoneexample.com, the script will first try to findfoo.example.comin Route53 zones, and if not found, it will assume it is a hostname, strip out thefoo.and try to findexample.comzone. In that zone it will create the TXT field for the Letsencrypt DNs challenge.Should fix #9