Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alpha-values false positives for <number> #92

Closed
EvgenyOrekhov opened this issue Nov 12, 2023 · 2 comments · Fixed by #93
Closed

Fix alpha-values false positives for <number> #92

EvgenyOrekhov opened this issue Nov 12, 2023 · 2 comments · Fixed by #93
Labels
bug Something isn't working

Comments

@EvgenyOrekhov
Copy link

What steps are needed to reproduce the bug?

Rule config: "scales/alpha-values": [0, 50, 100]

Input:

.foo {
  opacity: 0.5;
}

What did you expect to happen?

I expected that autofix will not be applied, since it's a numeric value, not percentage

What actually happened?

Output:

.foo {
  opacity: 0;
}
@EvgenyOrekhov
Copy link
Author

If I enable "alpha-value-notation": "percentage", alpha-values fixer applies first, and I still end up with an invalid value:

.foo {
  opacity: 0%;
}

@jeddy3 jeddy3 changed the title alpha-values autofixes numeric values Fix alpha-values false positives for <number> Nov 13, 2023
@jeddy3 jeddy3 added the bug Something isn't working label Nov 13, 2023
@jeddy3 jeddy3 mentioned this issue Nov 13, 2023
Merged
@jeddy3
Copy link
Owner

jeddy3 commented Nov 13, 2023

@EvgenyOrekhov Thanks for the report. Fixed in 3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix alpha-values false positives for <number> jeddy3/stylelint-scales
2 participants
@jeddy3 @EvgenyOrekhov