Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2 doesn't work #229

Closed
mikemix opened this issue Dec 6, 2018 · 2 comments
Closed

Version 2 doesn't work #229

mikemix opened this issue Dec 6, 2018 · 2 comments

Comments

@mikemix
Copy link

mikemix commented Dec 6, 2018 •
edited

@jedfoster example: https://jsfiddle.net/0679fux2/3/
At least in latest stable Firefox. Looks like the overflow: hidden is missing.

Previous version 1.0.0 works well.
@mikemix mikemix changed the title Doesn't work in Bootstrap Version 2 doesn't work in Bootstrap Dec 6, 2018
@mikemix mikemix changed the title Version 2 doesn't work in Bootstrap Version 2 doesn't work Dec 6, 2018
soundslocke added a commit to GigSalad/Readmore.js that referenced this issue Jan 8, 2019
@soundslocke
Add missing overflow property
1e05b07 
The CSS overflow property is now added to the element upon which
readmore is applied, which allows the plugin to continue working in
jQuery 3.x.

Resolves jedfoster#229
@soundslocke
Copy link

soundslocke commented Jan 8, 2019 •
edited

Interestingly it seems to still work when used with versions of jQuery prior to 3.x. I didn't trace down what jQuery change causes the break but adding the appropriate overflow property in readmore.js fixes this. See our fork.

I didn't try it out but the upcoming new version of readmore might work fine and not have this problem?

@jedfoster
Copy link
Owner

Something changed in jQuery 3. Not sure what, but I'm dropping support for jQuery altogether. I haven't used it on a project in nearly five years. Readmore.js v3 should fix a lot of the jQuery-related issues that have come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jedfoster @soundslocke @mikemix