Remove support for ruby 1.9.3 #1083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for metadata was added in rubygems 1.9.0. Any versions before this will fail on errors listed in jedi4ever#1029
Ruby 1.9.3 has been EOL'd earlier this year. A lot of veewee's gem requirements now require >= 2.x so its time to remove support and testing of 1.9.3
|
Just checking in on this pull request. Have a chance to look at this @mpapis ? |
|
what's the value of this PR? is there any code that would get improved? I do not feel like it's worth breaking compatibility for people that already have installed veewee on older ruby. Closing, if you can present compelling case to reopen I will reconsider. |
mpapis
added a commit
that referenced
this pull request
Mar 26, 2016
|
all works now on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 1.9.3 has been EOL'd earlier this year. A lot of
veewee's gem requirements now require >= 2.x so its time
to remove support and testing of 1.9.3.