Skip to content

Commit

Permalink
progress: Tracker.ETA() should return remaining time (not total)
Browse files Browse the repository at this point in the history
  • Loading branch information
jedib0t committed Aug 23, 2018
1 parent 250ffce commit 3fffd64
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion progress/tracker.go
Expand Up @@ -32,7 +32,7 @@ func (t *Tracker) ETA() time.Duration {
}

timeTaken := time.Since(t.timeStart)
eta := time.Duration((int64(timeTaken) / int64(percDone)) * 100)
eta := time.Duration((int64(timeTaken) / int64(percDone)) * int64(100-percDone))
return eta
}

Expand Down
4 changes: 2 additions & 2 deletions progress/tracker_test.go
Expand Up @@ -13,10 +13,10 @@ func TestTracker_ETA(t *testing.T) {

tracker.timeStart = time.Now()
time.Sleep(time.Millisecond * 100)
tracker.value = 10
tracker.value = 50
eta := tracker.ETA()
assert.NotEqual(t, time.Duration(0), eta)
assert.True(t, eta > time.Second)
assert.True(t, eta < time.Second)
}

func TestTracker_Increment(t *testing.T) {
Expand Down

0 comments on commit 3fffd64

Please sign in to comment.