Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text: support strfmt.DateTime objects in NewTimeTransformer #123

Merged
merged 1 commit into from
May 27, 2020
Merged

text: support strfmt.DateTime objects in NewTimeTransformer #123

merged 1 commit into from
May 27, 2020

Conversation

jedib0t
Copy link
Owner

@jedib0t jedib0t commented May 27, 2020

PR #122 removed dependency on go-openapi/strfmt and removed a ton of unnecessary transitive dependencies. However, this also removed support for strfmt.DateTime in NewTimeTransformer. This change re-introduces support for strfmt.DateTime objects indirectly by parsing the String() form of the object with some common time layouts.

@jedib0t jedib0t merged commit fccf2a0 into master May 27, 2020
@jedib0t jedib0t deleted the text-strfmt-datetime branch May 27, 2020 20:07
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1a2f91f on text-strfmt-datetime into efc0c98 on master.

@jedib0t jedib0t mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jedib0t @coveralls