Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: handle race conditions; fixes #81 #83

Merged
merged 1 commit into from
May 30, 2019
Merged

Conversation

jedib0t
Copy link
Owner

@jedib0t jedib0t commented May 30, 2019

@Haraguroicha found a bunch of race conditions and unsafe access of a lot of properties in Progress Writer and opened a PR with fixes for the same @ #81

The other PR is out of date with master branch and has not been re-based yet. So, this PR attempts to do the same things as #81 and some more:

  • cleaner mutex usage and new Length* interfaces
  • introduce a Make step to check for race conditions using the pre-built progress demo
  • modify the Travis config to check and fail for race conditions with every run

Fixes #81.

@coveralls
Copy link

coveralls commented May 30, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d281e8b on progress-race into 918cee6 on master.

@jedib0t jedib0t merged commit f5c9bfa into master May 30, 2019
@jedib0t jedib0t deleted the progress-race branch May 30, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants