Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use Django>=3.1 #134

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Allow use Django>=3.1 #134

merged 2 commits into from
Dec 11, 2020

Conversation

ron8mcr
Copy link
Contributor

@ron8mcr ron8mcr commented Aug 10, 2020

`--no-print-logs` was deprecated in
https://github.com/pytest-dev/pytest/pull/6333/files

And should be replaced with `--show-capture=no`
This resolves #131, so Django now added as transitive dependency
of `django-reversion`.

Also add Django==3.1 to test matrix
@ron8mcr
Copy link
Contributor Author

ron8mcr commented Aug 10, 2020

Sorry, build is broken, poetry and tox integration is not so simple:
python-poetry/poetry#1745

In my local environment, everything worked OK as poetry installed Django==3.0 first, and all tests in all environments was run with this version (as poetry install runs after tox prepared virtualnev).
So tests cannot be run until django-tools will be fixed

@zymergen-stian
Copy link

zymergen-stian commented Dec 2, 2020

Any progress on this one? Due to the new stricter pip resolver, I can no longer turn a blind eye on django-reversion-compare==0.12.2 with Django>=3.1 now.

Looks like master build was failing before this PR, so should it be blocking on this change?

@jedie jedie merged commit 3a171a8 into jedie:master Dec 11, 2020
@nschlemm
Copy link

@jedie THX for merging this - any plans when this will be released? :)

@jedie
Copy link
Owner

jedie commented Dec 23, 2020

thanks for the reminder ;)

It's not released as v0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants