Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #148 add a compare fallback #149

Merged
merged 1 commit into from Feb 24, 2021
Merged

Conversation

jedie
Copy link
Owner

@jedie jedie commented Feb 24, 2021

work-a-round for: etianen/django-reversion#859

The test project creates a example. This compare must use the fallback:

grafik

The fallback compare diff looks in this case like this:

grafik

@jedie jedie force-pushed the issues148-incompatible-version-data branch from 39b03db to bbce577 Compare February 24, 2021 13:02
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #149 (cb63680) into master (c03fed8) will decrease coverage by 0.50%.
The diff coverage is 75.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   88.02%   87.52%   -0.51%     
==========================================
  Files          33       38       +5     
  Lines        1604     1732     +128     
  Branches      164      165       +1     
==========================================
+ Hits         1412     1516     +104     
- Misses        144      168      +24     
  Partials       48       48              
Impacted Files Coverage Δ
reversion_compare_tests/settings.py 100.00% <ø> (ø)
reversion_compare_tests/test_basics.py 100.00% <ø> (ø)
...compare_tests/migrations/0003_migration_model_2.py 27.27% <27.27%> (ø)
...compare_tests/migrations/0002_migration_model_1.py 36.84% <36.84%> (ø)
reversion_compare/compare_raw.py 88.23% <88.23%> (ø)
reversion_compare_tests/utils/fixtures.py 79.90% <88.23%> (+0.71%) ⬆️
reversion_compare/admin.py 87.27% <95.45%> (+1.71%) ⬆️
reversion_compare_tests/admin.py 100.00% <100.00%> (ø)
reversion_compare_tests/migrations/0001_initial.py 100.00% <100.00%> (ø)
reversion_compare_tests/models.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03fed8...cb63680. Read the comment docs.

@jedie jedie force-pushed the issues148-incompatible-version-data branch from bbce577 to e9fc761 Compare February 24, 2021 13:54
work-a-round for: etianen/django-reversion#859

The test project creates a example. This compare must use the fallback:

![grafik](https://user-images.githubusercontent.com/71315/109011223-f57f1480-76b0-11eb-9055-2aad30cd566e.png)

The fallback compare diff looks in this case like this:

![grafik](https://user-images.githubusercontent.com/71315/109011333-0f205c00-76b1-11eb-8a6c-6c439710d5b5.png)
@jedie jedie force-pushed the issues148-incompatible-version-data branch from e9fc761 to cb63680 Compare February 24, 2021 14:23
@jedie jedie changed the title WIP: Fix #148 add a compare fallback Fix #148 add a compare fallback Feb 24, 2021
@jedie jedie merged commit 62d44c9 into master Feb 24, 2021
@jedie jedie deleted the issues148-incompatible-version-data branch February 24, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant