Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 build fails after updating from 1.0.18 to 1.0.19 #1313

Closed
Alexander-Wilms opened this issue Sep 13, 2023 · 2 comments
Closed

aarch64 build fails after updating from 1.0.18 to 1.0.19 #1313

Alexander-Wilms opened this issue Sep 13, 2023 · 2 comments

Comments

@Alexander-Wilms
Copy link

The Octave Flatpak package uses libsodium and version 1.0.18 was built successfully:

Cf. CI of latest commit to https://github.com/flathub/org.octave.Octave

But after updating libsodium, the build failed:

https://github.com/flathub/org.octave.Octave/pull/307/files

crypto_aead/aegis128l/aegis128l_armcrypto.c:23:9: error: pragma or attribute ‘target("neon")’ is not valid
   23 | #pragma GCC target("neon,crypto,aes")
      |         ^~~

crypto_aead/aegis256/aegis256_armcrypto.c:23:9: error: pragma or attribute ‘target("neon")’ is not valid
   23 | #pragma GCC target("neon,crypto,aes")
      |         ^~~

See https://buildbot.flathub.org/#/builders/6/builds/65343 for a complete log, which I've attached as well: stdio.txt

@cschug
Copy link

cschug commented Sep 13, 2023

Had the same issue on aarch64 and can confirm that fb4533b fixes the issue, thanks a lot!

@jedisct1
Copy link
Owner

Thank you!

The tag has been updated to the current stable, that includes that fix, thanks!

Repository owner locked and limited conversation to collaborators Dec 13, 2023
ghazel pushed a commit to clostra/libsodium that referenced this issue Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants