Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't crypto_pwdhash_PRIMITIVE be 'argon2id' ? #1331

Closed
zedalaye opened this issue Nov 10, 2023 · 1 comment
Closed

Shouldn't crypto_pwdhash_PRIMITIVE be 'argon2id' ? #1331

zedalaye opened this issue Nov 10, 2023 · 1 comment

Comments

@zedalaye
Copy link

Hi,

As almost all constants in this file references those of crypto_pwhash_argon2id.h, shouldn't crypto_pwdhash_PRIMITIVE be, in fact "argon2id" ?

https://github.com/jedisct1/libsodium/blob/6ee5a7345296a0a104fc3630bcea56e2f9f0f513/src/libsodium/include/sodium/crypto_pwhash.h#L138C14-L138C14
jedisct1 added a commit that referenced this issue Nov 10, 2023
@jedisct1
Include argon2id in crypto_pwhash_primitive()
4e0fcac 
Fixes #1331
@jedisct1
Copy link
Owner

Good catch!

We should list both, as they are both supported by the high-level APIs.

Thanks!

jedisct1 added a commit that referenced this issue Nov 10, 2023
@jedisct1
Include argon2id in crypto_pwhash_primitive()
39184b5 
Fixes #1331
jedisct1 added a commit that referenced this issue Nov 10, 2023
@jedisct1
Include argon2id in crypto_pwhash_primitive()
f1184e4 
Fixes #1331
enclave-alistair pushed a commit to enclave-alistair/libsodium that referenced this issue Dec 11, 2023
@jedisct1 @enclave-alistair
Include argon2id in crypto_pwhash_primitive()
98b3f1c 
Fixes jedisct1#1331
Repository owner locked and limited conversation to collaborators Feb 9, 2024
ghazel pushed a commit to clostra/libsodium that referenced this issue Feb 23, 2024
@jedisct1 @ghazel
Include argon2id in crypto_pwhash_primitive()
abc8f10 
Fixes jedisct1#1331
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zedalaye @jedisct1