Skip to content
Permalink
Browse files Browse the repository at this point in the history
diraliases: always set the tail of the list to NULL
Spotted and reported by Antonio Norales from GitHub Security Labs.
Thanks!
  • Loading branch information
jedisct1 committed Feb 18, 2020
1 parent a81471d commit 8d0d425
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/diraliases.c
Expand Up @@ -93,7 +93,6 @@ int init_aliases(void)
(tail->dir = strdup(dir)) == NULL) {
die_mem();
}
tail->next = NULL;
} else {
DirAlias *curr;

Expand All @@ -105,6 +104,7 @@ int init_aliases(void)
tail->next = curr;
tail = curr;
}
tail->next = NULL;
}
fclose(fp);
aliases_up++;
Expand Down

2 comments on commit 8d0d425

@leveryd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this security bug 's impact?

@jedisct1
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None.

Please sign in to comment.