Remove O_NOFOLLOW on opening of quota file #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason for |
|
Oh i see. But if i would manually follow symlink before opening it and verified that the target file has same name as the inputed one, but diffrent path? Worst thing that could happen is that somebody would rewrite someone else quota or make some files in FileSystem. Or add field to users in database that will contain path to .ftpquota. That would be better solution i think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to use O_NOFOLLOW. Since .ftpquota is a reserved name for pure-ftpd. We would like to use symlinks for shared quotas across multiple users. Therefore, I am sending a request for a small update :-).