Fix unix login with yescrypt hashed passwords #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should make that change only for relevant systems. Is there a macro defined when it's available? |
|
I couldn't find a macro that indicates yescrypt is available in crypt.h. The closest thing is XCRYPT_VERSION_NUM but I don't know if it's a good idea to rely on this implementation-specific macro. I can add a check for XCRYPT_VERSION_NUM if you wish. |
|
xcrypt is probably the only implementation used in linux distros, so that should be fine. |
Increase the MAX_DATA_SIZE when libxcrypt is used to accomodate yescrypt. This was discussed in https://forums.fedoraforum.org/showthread.php?332193-Problems-with-unix-authentication-in-pure-ftpd&p=1881101
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the MAX_DATA_SIZE to accomodate yescrypt, which is now the default in some distros. This was discussed in https://forums.fedoraforum.org/showthread.php?332193-Problems-with-unix-authentication-in-pure-ftpd&p=1881101 . I also tested the fix myself. 32M is the smallest power of 2 size that works.