Fix building in case of HAVE_EXPLICIT_BZERO #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if toolchain has implementation of explicit_bzero() and so HAVE_EXPLICIT_BZERO gets defined during configuration compilation will fail that way: ------------------------------------>8------------------------------ utils.c: In function 'pure_memzero': utils.c:49:1: error: expected declaration or statement at end of input } ^ ------------------------------------>8------------------------------ That happens because closing "#endif" is put 1 line below than really meant. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
jedisct1
added a commit
that referenced
this pull request
Jul 9, 2015
Fix building in case of HAVE_EXPLICIT_BZERO
|
Good catch. I indeed hadn't tried on Bitrig/OpenBSD without libsodum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if toolchain has implementation of explicit_bzero() and so
HAVE_EXPLICIT_BZERO gets defined during configuration compilation will
fail that way:
------------------------------------>8------------------------------
utils.c: In function 'pure_memzero':
utils.c:49:1: error: expected declaration or statement at end of input
}
^
------------------------------------>8------------------------------
That happens because closing "#endif" is put 1 line below than really
meant.
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com