This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
Update plugin version in plugin.xml to 1.9.0 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2017
|
I could merge, as this is very simple, but I can't publish to npm, so we'll need an official contributor on this. |
|
@fredgalvao I don't have access to a computer until tomorrow evening but can give you access to npm if you give me your username |
|
@jeduan I don't have one yet, and I can't create one atm either (I'll send it to you as soon as I create it). I'm guessing tomorrow evening is fine. Thanks for taking the time, regardless. |
bandeto45
approved these changes
Jun 3, 2017
Lindsay-Needs-Sleep
pushed a commit
to miloproductionsinc/cordova-plugin-facebook-connect
that referenced
this pull request
Mar 7, 2020
Lindsay-Needs-Sleep
pushed a commit
to miloproductionsinc/cordova-plugin-facebook-connect
that referenced
this pull request
Mar 7, 2020
Lindsay-Needs-Sleep
pushed a commit
to miloproductionsinc/cordova-plugin-facebook-connect
that referenced
this pull request
Mar 7, 2020
Lindsay-Needs-Sleep
pushed a commit
to miloproductionsinc/cordova-plugin-facebook-connect
that referenced
this pull request
Mar 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the original PR #485 has broken the build process when installed via npm, as mentioned here:
Closes #497
Closes #506
Closes #507
And the comment in #506 (comment) alerted me to the fact that it was probably caused by merging my previous PR which set to it to 1.8.0 when that was the latest version.
So hopefully merging this one change will fix it for everyone.