Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Fix openUrl handling bugs and add support for cordova-ios-5 #751

Merged
merged 7 commits into from
Jun 29, 2019
Merged

Fix openUrl handling bugs and add support for cordova-ios-5 #751

merged 7 commits into from
Jun 29, 2019

Conversation

guylando
Copy link

Fix #750

@guylando guylando mentioned this pull request Feb 21, 2019
Closed
@GexxOn
Copy link

GexxOn commented Mar 20, 2019

oh, just saw this PR - we ran into exactly the same issue and also discovered the same solution. pLease merge this!! (or ours ;))

@GexxOn GexxOn mentioned this pull request Mar 20, 2019
Closed
@guylando
Upgraded facebook sdk to 5.0.2
3593a46
@guylando
Fix calls to deprecated facebook sdk functions on android which cause…
92189a0 
…d runtime crash when called.
@guylando
Removing Bolts framework ios dependency which is not used in ios sdk v5
a1a69b3 
facebook/facebook-ios-sdk@0bdd850
@guylando
Modernized FBSDKLoginKit usage according to
060a007 
facebook/facebook-ios-sdk@6c4ac12
facebook/facebook-ios-sdk@5eae2d7:

1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock
2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions

Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb:

1. Updated FBSDKShareOpenGraphAction init to actionWithType
2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock
@guylando
Copy link
Author

This now also fixes #770 by updating facebook android AND ios sdks to version 5.0.2.
If someone wants to use my fork (https://github.com/guylando/cordova-plugin-facebook4) until it gets merged then run:
cordova plugin remove cordova-plugin-facebook4
cordova plugin add https://github.com/guylando/cordova-plugin-facebook4 --save --variable APP_ID="123456789" --variable APP_NAME="myApplication"
replace 123456789 with your app id and myApplication with your app name

@guylando guylando mentioned this pull request Jun 13, 2019
Closed
@igorkurochka
Copy link

@guylando I've installed your fork and am getting crash on iOS, looks like handling openURL never ends, I've got thousands of this message in xcode console before it crashes:
2019-06-17 09:14:51.592862+0300 My Project[575:95449] FB handle url using application:openURL:options: fb54303189618000://authorize#access_token=...&data_access_expiration_time=1568528083&denied_scopes=&expires_in=5120025&granted_scopes=email%2Cpublic_profile&signed_request=...&state=%7B%22challenge%22%3A%22rgvXLvVXtmApSpc1hxQ5I3gk3U4%253D%22%2C%220_auth_logger_id%22%3A%2233AA6FF6-055E-4BD7-87A8-AE185A4BBD15%22%2C%22com.facebook.sdk_client_state%22%3Atrue%2C%223_method%22%3A%22sfvc_auth%22%7D

any ideas how to fix?

@guylando
Copy link
Author

guylando commented Jun 17, 2019 •
edited

@igorkurochka did you do this #750 (comment) ? as written in installation instructions here https://github.com/guylando/cordova-plugin-facebook4#installation

@gustavokloh
Copy link

Hey maintainers :D
Do you will merge this PR? It will help a lot.

Thanks!

@HodayaGruzman
Copy link

hey, I really need that pr too.
please merge it, I need it for facebook android AND ios sdks to version 5.0.2.

@vvarda
Copy link

vvarda commented Jun 24, 2019

@guylando installing this fork stucks.

cordova plugin add https://github.com/guylando/cordova-plugin-facebook4 --save --variable APP_ID="123456789" --variable APP_NAME="myApplication"
or
npm install --save https://github.com/guylando/cordova-plugin-facebook4.git

What's the problem? Another npm-packages or cordova-plugins install normally.

@guylando
Copy link
Author

@vvarda this plugin is huge so it takes a lot of time, just leave it and go eat something

@peterpeterparker peterpeterparker merged commit 03ca9ab into jeduan:master Jun 29, 2019
@peterpeterparker
Copy link
Collaborator

thx @guylando for the amazing work 👍

This was referenced Jun 29, 2019
Closed
Closed
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this pull request Mar 7, 2020
@guylando @peterpeterparker
Fix openUrl handling bugs and add support for cordova-ios-5 (jeduan#751)
ae682b7 
* Update FacebookConnectPlugin.m

Fix jeduan#750

* Update README.md

* Upgraded facebook sdk to 5.0.2

* Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called.

* Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850

* Modernized FBSDKLoginKit usage according to
facebook/facebook-ios-sdk@6c4ac12
facebook/facebook-ios-sdk@5eae2d7:

1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock
2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions

Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb:

1. Updated FBSDKShareOpenGraphAction init to actionWithType
2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock

* removed irrelevant files
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this pull request Mar 7, 2020
@guylando @peterpeterparker
Fix openUrl handling bugs and add support for cordova-ios-5 (jeduan#751)
0e9613b 
* Update FacebookConnectPlugin.m

Fix jeduan#750

* Update README.md

* Upgraded facebook sdk to 5.0.2

* Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called.

* Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850

* Modernized FBSDKLoginKit usage according to
facebook/facebook-ios-sdk@6c4ac12
facebook/facebook-ios-sdk@5eae2d7:

1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock
2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions

Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb:

1. Updated FBSDKShareOpenGraphAction init to actionWithType
2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock

* removed irrelevant files
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this pull request Mar 7, 2020
@guylando @peterpeterparker
Fix openUrl handling bugs and add support for cordova-ios-5 (jeduan#751)
a41f308 
* Update FacebookConnectPlugin.m

Fix jeduan#750

* Update README.md

* Upgraded facebook sdk to 5.0.2

* Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called.

* Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850

* Modernized FBSDKLoginKit usage according to
facebook/facebook-ios-sdk@6c4ac12
facebook/facebook-ios-sdk@5eae2d7:

1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock
2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions

Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb:

1. Updated FBSDKShareOpenGraphAction init to actionWithType
2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock

* removed irrelevant files
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this pull request Mar 7, 2020
@guylando @peterpeterparker
Fix openUrl handling bugs and add support for cordova-ios-5 (jeduan#751)
8633acd 
* Update FacebookConnectPlugin.m

Fix jeduan#750

* Update README.md

* Upgraded facebook sdk to 5.0.2

* Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called.

* Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850

* Modernized FBSDKLoginKit usage according to
facebook/facebook-ios-sdk@6c4ac12
facebook/facebook-ios-sdk@5eae2d7:

1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock
2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions

Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb:

1. Updated FBSDKShareOpenGraphAction init to actionWithType
2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock

* removed irrelevant files
@noahcooper noahcooper mentioned this pull request Jan 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing swizzle for application:openURL:options in ios
7 participants
@guylando @GexxOn @igorkurochka @gustavokloh @HodayaGruzman @vvarda @peterpeterparker