Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Fix Facebook login on iOS 13 #860

Closed
wants to merge 1 commit into from

Conversation

jonasmeier1212
Copy link

Applied fix from here: #826
This fix works without problems on all iOS version.
It implements the code examples from Facebook in the plugin code, which makes additional docu or post scripts obsolete.

@peterpeterparker
Copy link
Collaborator

@jonasmeier1212 thx for the PR

what do you mean with "which makes additional docu or post scripts obsolete."? should also the docs be updated, if so, could you add the change to the PR too?

@peterpeterparker
Copy link
Collaborator

@jonasmeier1212 is the PR really needed ? I just tested current version of the plugin as described in #826 with my iPhone 6s iOS 13.3 and I'm unable to reproduce the problem.

Therefore too me this doesn't have to be merged or how could effectively be the problem be reproduced?

@lonwi
Copy link

lonwi commented May 28, 2020

@peterpeterparker You need to have a Facebook App installed to replicate the problem just in case. I had to clear all safari data as well as it remembered my login without the Facebook App installed. I was able to replicate the issue on ios 13.3 and 13.5 on a couple of the devices.

@kleeb
Copy link

kleeb commented Jun 26, 2020

I was able to reproduce that on iPhone 6 with iOS 12.4.3 and on iPhone 8 Plus with iOS 13.5.1.
Its not occuring on iPhoneX with iOS 13.4.

This PR is nothing else like an add-on to this issue facebook/facebook-ios-sdk#1400
Let's not wait longer with merging.

@rareplanet1
Copy link

Will this be merged?
Reproduced today on iOS 14.2 on iPhone 12 mini and iPhone 7 Plus
Using cordova-ios@6.1.1 and cordova-plugin-facebook4@6.4.0

@anuradha-newpage
Copy link

Is this going to be merged anytime soon? The issue occurs on iOS 14.2 with cordova-plugin-facebook4@6.4.0 and capacitor/ios@2.4.1

@noahcooper
Copy link
Collaborator

This plugin is deprecated. Check out cordova-plugin-facebook-connect. I've included the changes from the PR by @jonasmeier1212:

https://www.npmjs.com/package/cordova-plugin-facebook-connect

@noahcooper noahcooper closed this Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants