Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any type in value #25

Closed
bashmish opened this issue Dec 9, 2014 · 2 comments
Closed

Allow any type in value #25

bashmish opened this issue Dec 9, 2014 · 2 comments

Comments

@bashmish
Copy link

bashmish commented Dec 9, 2014

HTML options tag doesn't allow value to be any other type than string. But this component should allow this because it is usually more convenient to make values as integer ids. Developers shouldn't always make conversion from string to int and vice versa themselves.
jacobdfriedmann added a commit to jacobdfriedmann/react-select that referenced this issue Dec 10, 2014
@jacobdfriedmann
Ref JedWatson#25 - Allows numbers (not just strings) as option labels…
57e9386 
… and values.

If a multi-select, passes an array to the onChange function (instead of concatenated string)
which is empty when nothing is selected.

If a single select, passes the single value to the onChange function and null if nothing
is selected.
jacobdfriedmann added a commit to jacobdfriedmann/react-select that referenced this issue Jan 4, 2015
@jacobdfriedmann
Ref JedWatson#25 - Allows numbers (not just strings) as option labels…
ea5d9c3 
… and values.

If a multi-select, passes an array to the onChange function (instead of concatenated string)
which is empty when nothing is selected.

If a single select, passes the single value to the onChange function and null if nothing
is selected.
jacobdfriedmann added a commit to jacobdfriedmann/react-select that referenced this issue Jan 12, 2015
@jacobdfriedmann
Ref JedWatson#25 - Allows numbers (not just strings) as option labels…
ea4315f 
… and values.

If a multi-select, passes an array to the onChange function (instead of concatenated string)
which is empty when nothing is selected.

If a single select, passes the single value to the onChange function and null if nothing
is selected.
@julen julen mentioned this issue Feb 14, 2015
Closed
@RusAlex
Copy link

RusAlex commented Apr 10, 2015

IMHO it must stay as strict as possible and do not allow non-strings to be values.

@dcousens dcousens closed this as completed May 7, 2015
@dcousens dcousens reopened this May 7, 2015
This was referenced May 7, 2015
Closed
Closed
@dcousens
Copy link
Collaborator

dcousens commented May 7, 2015

Closed in favour of #45.

@dcousens dcousens closed this as completed May 7, 2015
@brianreavis brianreavis mentioned this issue Jun 1, 2015
Closed
12 tasks
bkoltai pushed a commit to bkoltai/react-select that referenced this issue Sep 20, 2017
@TrevorBurnham
Merge pull request JedWatson#25 from HubSpot/update-to-upstream-beta-…
c3792a5 
…13-patch

Update to latest upstream master
Methuselah96 added a commit to Methuselah96/react-select that referenced this issue Nov 22, 2020
@Methuselah96
Memoize components internally to help remove UNSAFE React methods fro…
821c397 
…m Select (JedWatson#25)

* Use memoization function to access components

* Create thirty-islands-remain.md

* Rename method

* Make method

* Delete thirty-islands-remain.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bashmish @RusAlex @dcousens