-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch JsonRpc ? #2386
Comments
Hello, |
Hi, thanks for the response, it is however possible to limit the number of requests allowed in a batch to take care of sure scenario with an optional "batchLimit" parameter. |
Hello, |
[EN] Hi, the limit indeed depends on usage but a sensible default that one can customize as a global option as those present in core/config/default.config.ini sould do the trick. A plugin would not be a good way to go, as the jsonRpc api should implement the jsonRpc specification (linked at the top of the Jeedom jsonRpc documentation) and more specificaly :
[FR] Bonjour, oui la limite dépend de l'usage, mais un paramètre global avec une valeur par défaut dans core/config/default.config.ini, me semble mieux que l'absence d'implémentation. Utiliser un plugin en remplacement de l'api jsonRpc, n'est pas une solution long terme pour ce cas précis car il s'agit d'une partie de l'implementation du protocole jsonRpc. Plus précisement le 6 chapitre de la spécification jsonRpc librement traduite comme suis :
|
Bonjour, Clairement cette modification me fait peur elle va être très lourde et impactante pour un usage vraiment restreint (1er demande en 10ans...). Je vais la remonter a l'équipe Jeedom c'est eux qui ont le dernier mot. |
Bonjour, |
Hi, it appears to me that you currently use an internal implementation of JsonRpc that does not take care of batch requests and I happen to be in need for them for performance issue (The Jeedom is on a small board with a limited 4G connection so limiting network calls helps a lot)
Would it be possible to either develop a support for batch requests or transition towards a lib that does so ?
I did some check and 1ma/JsonRpc seems to be quit documented and usable while also being license compatible (MIT).
If you need a PR for doing so, please let us know.
The text was updated successfully, but these errors were encountered: